feat(dotfiles): enhance setup script with login manager commands#150
Merged
shiron-dev merged 2 commits intomainfrom Jul 6, 2025
Merged
feat(dotfiles): enhance setup script with login manager commands#150shiron-dev merged 2 commits intomainfrom
shiron-dev merged 2 commits intomainfrom
Conversation
Owner
shiron-dev
commented
Jul 6, 2025
shiron-dev
commented
- Added commands to check and import configurations using the login manager in the setup script.
- This improvement streamlines the setup process by integrating login management functionalities.
- Added commands to check and import configurations using the login manager in the setup script. - This improvement streamlines the setup process by integrating login management functionalities.
Contributor
|
PRのスコープが正しくありません。 |
shiron-dev
changed the title
shiron-dev
force-pushed
the
feat/login
branch
3 times, most recently
from
549a8f3 to
be1536f
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
- Refactored the `_get_current_items_as_yaml` function to directly pipe the output of the `osascript` command into the while loop, improving readability and efficiency. - Added a `trap` command to ensure the temporary YAML file is removed upon exit, enhancing resource management. - Removed redundant `rm` command for the temporary file, as cleanup is now handled by the trap. These changes aim to simplify the script and ensure better handling of temporary files. fix(login_manager): improve error handling for osascript commands - Added error checks for `osascript` commands in `_get_current_items_as_yaml` and `import_login_items` functions to handle failures gracefully. - Enhanced user feedback by printing error messages to stderr when `osascript` commands fail, ensuring better debugging and user awareness. - Wrapped the temporary YAML file handling in a subshell to maintain scope and improve readability. These changes aim to enhance the robustness of the login manager script by ensuring that errors are properly reported and handled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.