fix(ci): restrict PyPI publish to release events and manual triggers #477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the PyPI publishing workflow to run only on: 1. Release published events (not drafts) - using 'release: types: [published]' 2. Manual workflow_dispatch with version input Removes the 'push: tags:' trigger that ran on any tag push. This provides better control over when PyPI packages are published: - Releases can be prepared as drafts without triggering publish - Only finalized releases trigger automatic publishing - Manual override available via workflow_dispatch when needed Updated version detection logic: - Extracts version from github.event.release.tag_name for releases - Strips 'v' prefix if present - Falls back to workflow_dispatch version input - Errors if neither source is available Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
SafeDep Report Summary
No dependency changes detected. Nothing to scan. This report is generated by SafeDep Github App |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #477 +/- ##
=======================================
Coverage 79.94% 79.94%
=======================================
Files 101 101
Lines 11107 11107
=======================================
Hits 8880 8880
Misses 1879 1879
Partials 348 348 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Restricts the PyPI publishing workflow to run only on two specific events:
Why this change?
Currently the workflow runs on push: tags: v* which triggers on ANY tag push. This can lead to unintended PyPI publishes.
Changes
New Behavior
Option 1: Release Published (Automatic)
When you publish a release on GitHub, the workflow automatically triggers and publishes to PyPI.
Option 2: Manual Trigger (Override)
From GitHub Actions UI, navigate to Actions → Publish to PyPI → Run workflow with version number.
Benefits
🤖 Generated with Claude Code