Skip to content

Implement dequantizeLinear#134

Merged
huningxin merged 7 commits intoshiyi9801:ort_backendfrom
lisa0314:ort_backend
Feb 18, 2025
Merged

Implement dequantizeLinear#134
huningxin merged 7 commits intoshiyi9801:ort_backendfrom
lisa0314:ort_backend

Conversation

@lisa0314
Copy link
Copy Markdown
Collaborator

@lisa0314 lisa0314 commented Feb 11, 2025

The implementation of dequantizelinear is a little confusion since currently WebNN spec definition for dequantizelinear is wildly different from ONNX. Besides, OpenVINO also have many constraints.

Comment thread services/webnn/ort/graph_builder_ort.cc Outdated
Comment thread services/webnn/ort/graph_builder_ort.cc Outdated
Comment thread services/webnn/ort/graph_builder_ort.cc
Comment thread services/webnn/ort/graph_builder_ort.cc Outdated
Comment thread services/webnn/ort/graph_builder_ort.cc Outdated
Comment thread services/webnn/ort/graph_builder_ort.cc Outdated
Comment thread services/webnn/ort/graph_builder_ort.cc Outdated
Comment thread services/webnn/ort/graph_builder_ort.cc
@shiyi9801
Copy link
Copy Markdown
Owner

You'll need to rebase the code due to my latest force push, thanks!
/cc @mingmingtasd @miaobin @huningxin

@lisa0314
Copy link
Copy Markdown
Collaborator Author

@huningxin Please take another look. Thanks!

@lisa0314
Copy link
Copy Markdown
Collaborator Author

@huningxin Please hold on. I will upload a new commit to fix a bug.

@lisa0314
Copy link
Copy Markdown
Collaborator Author

@huningxin ready for review again. Thanks!

Comment thread services/webnn/ort/graph_builder_ort.cc Outdated
Comment thread services/webnn/ort/graph_builder_ort.cc Outdated
Comment thread services/webnn/ort/graph_builder_ort.cc Outdated
Comment thread services/webnn/ort/graph_builder_ort.cc Outdated
Comment thread services/webnn/ort/graph_builder_ort.cc Outdated
Comment thread services/webnn/ort/graph_builder_ort.cc Outdated
Comment thread services/webnn/ort/graph_builder_ort.cc Outdated
Comment thread services/webnn/ort/graph_builder_ort.cc Outdated
Comment thread services/webnn/ort/graph_builder_ort.cc Outdated
Comment thread services/webnn/ort/graph_builder_ort.cc
@lisa0314
Copy link
Copy Markdown
Collaborator Author

@huningxin Uploaded a new commit to address the remaining comments. Please take another look. Thanks!

Comment thread services/webnn/ort/graph_builder_ort.cc Outdated
Comment thread services/webnn/ort/graph_builder_ort.cc Outdated
Comment thread services/webnn/ort/graph_builder_ort.cc Outdated
Comment thread services/webnn/ort/graph_builder_ort.cc Outdated
Comment thread services/webnn/ort/graph_builder_ort.cc Outdated
Comment thread services/webnn/ort/graph_builder_ort.cc Outdated
Comment thread services/webnn/ort/graph_builder_ort.cc Outdated
Comment thread services/webnn/ort/graph_builder_ort.cc Outdated
Comment thread services/webnn/ort/graph_builder_ort.cc Outdated
Comment thread services/webnn/ort/ort_model_builder.cc
@lisa0314
Copy link
Copy Markdown
Collaborator Author

@huningxin Please take another look. Thanks!

Copy link
Copy Markdown
Collaborator

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit

Comment thread services/webnn/ort/graph_builder_ort.cc
Copy link
Copy Markdown
Collaborator

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants