Skip to content

Convert InstallCommand and UpdateCommand into invokable commands#256

Merged
acelaya merged 6 commits intoshlinkio:developfrom
acelaya-forks:symfony-cli-improvements
Dec 17, 2025
Merged

Convert InstallCommand and UpdateCommand into invokable commands#256
acelaya merged 6 commits intoshlinkio:developfrom
acelaya-forks:symfony-cli-improvements

Conversation

@acelaya
Copy link
Member

@acelaya acelaya commented Dec 17, 2025

Extract the common logic in InstallCommand and UpdateCommand to a reusable service that can be composed, instead of having a parent abstract class both commands extend from.

Then, convert both commands into invokable ones.

@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

❌ Patch coverage is 97.56098% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 97.93%. Comparing base (1be30af) to head (8d59ce7).
⚠️ Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
src/Service/InstallationRunner.php 96.66% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #256      +/-   ##
=============================================
- Coverage      97.95%   97.93%   -0.03%     
+ Complexity       323      320       -3     
=============================================
  Files             96       96              
  Lines            882      872      -10     
=============================================
- Hits             864      854      -10     
  Misses            18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@acelaya acelaya force-pushed the symfony-cli-improvements branch from 3f501a7 to 4d235be Compare December 17, 2025 08:53
@acelaya acelaya force-pushed the symfony-cli-improvements branch from 4d235be to ac89c6e Compare December 17, 2025 10:33
@acelaya acelaya merged commit 4585754 into shlinkio:develop Dec 17, 2025
5 checks passed
@acelaya acelaya deleted the symfony-cli-improvements branch December 17, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant