Skip to content

Convert SetOptionCommand into invokable command #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acelaya merged 1 commit into from
Dec 17, 2025
Merged

Convert SetOptionCommand into invokable command #257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 7 additions & 18 deletions src/Command/SetOptionCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,8 @@
use Shlinkio\Shlink\Installer\Service\ShlinkAssetsHandlerInterface;
use Shlinkio\Shlink\Installer\Util\ArrayUtils;
use Shlinkio\Shlink\Installer\Util\ConfigWriterInterface;
use Symfony\Component\Console\Attribute\AsCommand;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Style\SymfonyStyle;
use Symfony\Component\Filesystem\Filesystem;

Expand All @@ -25,6 +24,7 @@
use function is_numeric;
use function iterator_to_array;

#[AsCommand(SetOptionCommand::NAME, 'Allows you to set new values for any config option')]
class SetOptionCommand extends Command
{
public const string NAME = 'set-option';
Expand All @@ -33,10 +33,10 @@ class SetOptionCommand extends Command
private string $generatedConfigPath;

public function __construct(
private ConfigWriterInterface $configWriter,
private ShlinkAssetsHandlerInterface $assetsHandler,
private ConfigOptionsManagerInterface $optionsManager,
private Filesystem $filesystem,
private readonly ConfigWriterInterface $configWriter,
private readonly ShlinkAssetsHandlerInterface $assetsHandler,
private readonly ConfigOptionsManagerInterface $optionsManager,
private readonly Filesystem $filesystem,
array $groups,
array|null $enabledOptions,
) {
Expand All @@ -62,23 +62,12 @@ private function flattenGroupsWithTitle(iterable $groups): Generator
}
}

protected function configure(): void
{
$this
->setName(self::NAME)
->setDescription('Allows you to set new values for any config option.');
}

protected function interact(InputInterface $input, OutputInterface $output): void
public function __invoke(SymfonyStyle $io): int
{
if (! $this->filesystem->exists($this->generatedConfigPath)) {
throw InvalidShlinkPathException::forCurrentPath();
}
}

protected function execute(InputInterface $input, OutputInterface $output): int
{
$io = new SymfonyStyle($input, $output);
$optionTitle = $io->choice('What config option do you want to change', array_keys($this->groups));

/** @var ConfigOptionInterface $plugin */
Expand Down