Make GeoLite2 file decompression memory efficient#72
Closed
acelaya wants to merge 1 commit intoshlinkio:mainfrom
Closed
Make GeoLite2 file decompression memory efficient#72acelaya wants to merge 1 commit intoshlinkio:mainfrom
acelaya wants to merge 1 commit intoshlinkio:mainfrom
Conversation
62317b4 to
af0d94e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
============================================
- Coverage 97.02% 91.11% -5.92%
- Complexity 36 46 +10
============================================
Files 11 11
Lines 101 135 +34
============================================
+ Hits 98 123 +25
- Misses 3 12 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
af0d94e to
a4ba997
Compare
Member
Author
|
Superseded by #73 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #71
Refactor logic to decompress a GeoLite2 db file once it has been downloaded, so that we don't try to load the whole file in memory, but do it in chunks instead.
This ensures Shlink does not crash if the amount of memory reserved for it is lower than the GeoLite db file size.