Skip to content

Add WeScale in Proxy#131

Open
earayu wants to merge 1 commit intoshlomi-noach:masterfrom
earayu:patch-1
Open

Add WeScale in Proxy#131
earayu wants to merge 1 commit intoshlomi-noach:masterfrom
earayu:patch-1

Conversation

@earayu
Copy link

@earayu earayu commented Jun 27, 2024

No description provided.

@dveeden
Copy link
Collaborator

dveeden commented Jun 28, 2024

This seems to be Apache 2.0 licensed and fits well into the MySQL landscape. Looking at the code this seems to be based on or related to Vitess. However the readme didn't say anything about this, but that shouldn't block inclusion. @earayu if this is indeed based on Vitess you might want to explain that in the readme and give them credits.

@dveeden dveeden requested a review from shlomi-noach June 28, 2024 07:31
@earayu
Copy link
Author

earayu commented Jun 28, 2024

This seems to be Apache 2.0 licensed and fits well into the MySQL landscape. Looking at the code this seems to be based on or related to Vitess. However the readme didn't say anything about this, but that shouldn't block inclusion. @earayu if this is indeed based on Vitess you might want to explain that in the readme and give them credits.

Hi, @dveeden
In the README, there is clear text indicating that wescale was forked from vitess.

"WeScale is a fork of the Vitess project, which is a database clustering system for horizontal scaling of MySQL. We would like to thank the Vitess team for their hard work."

@dveeden
Copy link
Collaborator

dveeden commented Jun 28, 2024

@earayu ah yes. My bad. I was searching for this with Firefox and it already showed "Phrase not found" when I typed "Vit".... but I had enabled "Whole Words" in a previous search...

@earayu
Copy link
Author

earayu commented Sep 20, 2024

@shlomi-noach PTAL

@shlomi-noach
Copy link
Owner

I have some thoughts and as a disclaimer I am biased. I'll need assistance from an unbiased party (hopefully but not necessarily @dveeden) to review my thoughts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants