Skip to content

add sqlaxe to list of toolkits#133

Open
djberube wants to merge 2 commits intoshlomi-noach:masterfrom
djberube:add_sqlaxe
Open

add sqlaxe to list of toolkits#133
djberube wants to merge 2 commits intoshlomi-noach:masterfrom
djberube:add_sqlaxe

Conversation

@djberube
Copy link

@djberube djberube commented Jul 5, 2024

No description provided.

Copy link
Collaborator

@dveeden dveeden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MIT License, MySQL related. Looks like a useful tool.

It is also very new and looks like it might need many more iterations to reach maturity when it comes to features and stability.

It is leaning heavily on https://github.com/tobymao/sqlglot which is fine.

Co-authored-by: Daniël van Eeden <github@myname.nl>
@djberube
Copy link
Author

djberube commented Jul 5, 2024

Hard to believe I misspelled my own name in the PR. Thanks for the catch.

@dveeden dveeden requested a review from shlomi-noach July 5, 2024 16:15
@dveeden
Copy link
Collaborator

dveeden commented Jul 5, 2024

@djberube not related to this PR, but I would suggest to use a formatter like black and consider adding type annotations with mypy. But that of course is up to you. And maybe also consider publishing to pypi.

@djberube
Copy link
Author

djberube commented Jul 5, 2024

@dveeden yeah, that makes sense. I write a lot more Ruby code than Python - though that has been changing the last year or so. pypi is on the TODO list, and the other too suggestions make sense. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants