Fixes closable sl-alert can be closed on whole vertical area without visual indication#2375
Merged
claviska merged 2 commits intoshoelace-style:nextfrom Mar 11, 2025
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
claviska
approved these changes
Mar 11, 2025
Member
claviska
left a comment
claviska
left a comment
There was a problem hiding this comment.
Looks good and works great. Thanks for the PR!
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue, that the area above, under and on the right side of the closable icon button of the alert, also closes the alert without visual indication.
This PR avoids the strechting of the close icon and uses margin instead of padding for the close icon, as otherwise the padding is used as part of the close icon.
Closes #2374