Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions packages/webawesome/custom-elements-manifest.js
Original file line number Diff line number Diff line change
Expand Up @@ -194,11 +194,27 @@ export default {
},
}),

// Filter out events without names (these come from code analysis detecting
// dispatchEvent() calls, but lack the event name that comes from @event JSDoc tags)
{
name: 'wa-filter-unnamed-events',
packageLinkPhase({ customElementsManifest }) {
customElementsManifest?.modules?.forEach(mod => {
mod.declarations?.forEach(dec => {
if (dec.kind === 'class' && dec.events) {
dec.events = dec.events.filter(event => event.name);
}
});
});
},
},

// Generate JSX types (see https://wc-toolkit.com/integrations/jsx/)
jsxTypesPlugin({
fileName: 'custom-elements-jsx.d.ts',
outdir,
defaultExport: true,
includeDefaultDOMEvents: true,
componentTypePath: (_name, _tag, modulePath) => {
return `./${modulePath}`;
},
Expand Down
1 change: 1 addition & 0 deletions packages/webawesome/docs/docs/resources/changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ Components with the <wa-badge variant="warning">Experimental</wa-badge> badge sh
<small>TBD</small>

- Added `wa-button` class for styling `<a>` elements as buttons [pr:2040]
- Fixed a bug in the custom elements manifest where events may not have a name. [pr:2026]
- Fixed a bug in `<wa-select>` where options with `selected` set via framework property binding (e.g., Vue's `:selected`) were not respected when `with-clear` was present [pr:1985]
- Fixed a bug `<wa-color-picker>` that prevented it from flipping horizontally when position to the right of the viewport. [pr:2024]
- Fixed a bug by adding `color: inherit` to the `<wa-dialog>` and `<wa-drawer>` styles so they inherit the text color from the document context rather than the browser default. [pr:2064]
Expand Down
1 change: 0 additions & 1 deletion packages/webawesome/scripts/build.js
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,6 @@ export async function build(options = {}) {
}

spinner.succeed();

return Promise.resolve();
}

Expand Down