Skip to content

feat: add trusted headers #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TrayserCassa wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add trusted headers #137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion api/v1/store_env.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ func (s *Store) GetEnv() []corev1.EnvVar {
},
},
},
// When using https we need this for header trusting
// deprecated since 6.7
{
Name: "TRUSTED_PROXIES",
Value: "REMOTE_ADDR",
Expand All @@ -394,6 +394,10 @@ func (s *Store) GetEnv() []corev1.EnvVar {
Name: "SYMFONY_TRUSTED_PROXIES",
Value: "REMOTE_ADDR",
},
{
Name: "SYMFONY_TRUSTED_HEADERS",
Value: "['x-forwarded-for', 'x-forwarded-host', 'x-forwarded-proto', 'x-forwarded-port']",
Copy link
Member

@shyim shyim Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should test this before (I could imagine that they are just comma seperated) and allow also allow overwriting it by the user

Copy link
Contributor Author

@TrayserCassa TrayserCassa Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't found any documentation about this tbh, so I will test this later with my branch. Also add the possibility to change this.

},
// Some Shopware best practises
{
Name: "SHOPWARE_DBAL_TIMEZONE_SUPPORT_ENABLED",
Expand Down