amyboardweb: restore DX7 patch levels; skip disabled panes on DX7#907
Merged
amyboardweb: restore DX7 patch levels; skip disabled panes on DX7#907
Conversation
- amy_parameters.js: drop trailing ,,0,0 from OSCA/OSCB level change_code so the `a` (amp) command doesn't clobber EG0/LFO coefs. Mostly-restores DX7 patch sound. - Disable the Osc A pane (in addition to Osc B and ADSR) for DX7 presets in all three load paths: editor preset loader, spss patch loader, and the apply_zd_dump_to_knobs Pull path. - Skip disabled-section knobs in send_all_knob_cc_mappings and in the refresh_knobs_for_channel onKnobCcChange loop so disabled panes don't blast initial ic updates to AMY on DX7 preset load. Set the disabled state before send_all_knob_cc_mappings runs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
,,0,0from OSCA/OSCB levelchange_codeinamy_parameters.jsso thea(amp) command no longer clobbers EG0/LFO coefs — mostly-restores DX7 patch sound.editor/index.html),spss.jspatch loader (load_saved_patch_file_into_current_channel), andapply_zd_dump_to_knobs(Pull).send_all_knob_cc_mappings(spss.js) skips knobs whose section is inwindow._disabled_sections.refresh_knobs_for_channel(amy_parameters.js) skips theonKnobCcChangeloop for those knobs.send_all_knob_cc_mappings, so the skip takes effect on first load.Deployed to https://amyboard-wip.vercel.app for collaborator testing.
Test plan
ic…wire commands go out to AMY for Osc A / Osc B / ADSR knobs on initial load.,,0,0removal should restore amp).apply_zd_dump_to_knobs.🤖 Generated with Claude Code