NavigationBar fix for iPhone X, Xs Max, XR#434
Open
dongminkim wants to merge 3 commits intoshoutem:developfrom
Open
NavigationBar fix for iPhone X, Xs Max, XR#434dongminkim wants to merge 3 commits intoshoutem:developfrom
dongminkim wants to merge 3 commits intoshoutem:developfrom
Conversation
|
I am also facing this issue. Can we prioritize this PR and make this fix available soon please? |
simpleminds619
approved these changes
Aug 1, 2019
nightraiser
approved these changes
Aug 1, 2019
Author
|
I've tested commit c87ba00.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I've found that NavigationBar dimension issues, especially on iPhone X.
So I try to fix them, and they seems to be fixed.
Simulators are positioned like this on screeenshots:
[Before]

[After]

[Test Source Code]