fix/ Add lazy getters for initialWindowMetrics#907
Open
s-brankovic wants to merge 2 commits intodevelopfrom
Open
fix/ Add lazy getters for initialWindowMetrics#907s-brankovic wants to merge 2 commits intodevelopfrom
s-brankovic wants to merge 2 commits intodevelopfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: SafeArea inset constants crash when initialWindowMetrics is null
In react-native-safe-area-context v5, initialWindowMetrics can be null when the JS bundle evaluates before the native module initializes — a race condition common in large apps with many native modules. This caused HOME_INDICATOR_PADDING, NOTCH_AREA_HEIGHT, and NAVIGATION_BAR_HEIGHT to evaluate to undefined or NaN, leading to layout crashes.
Changes:
1. Added hardcoded fallbacks to the existing static constants via nullish coalescing:
2. Added lazy getter functions that resolve initialWindowMetrics on first call (render time) instead of import time:
Backward compatible — existing static constant exports are preserved. Consumers can migrate to the getter functions if needed.