Merged
Conversation
c7332f4 to
02e0af9
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds complex insert support to the SQL formatter, particularly improving how vertical spans mix with horizontal spans. The changes enhance tokenization support for SQL constructs like WINDOW clauses, DISTINCT FROM operators, ON CONFLICT clauses, and SET statements in UPDATE queries.
Key Changes:
- Adds new
ReservedNewlineAftertoken type for handling statements that need newlines after them - Expands tokenizer support for additional SQL keywords and constructs
- Improves span tracking to better handle inline vs. multi-line formatting decisions
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/tokenizer.rs | Adds ReservedNewlineAfter token type and support for WINDOW, ON CONFLICT, PARTITION BY, and DISTINCT FROM keywords |
| src/lib.rs | Adds Debug trait to SpanInfo and includes comprehensive tests for new formatting features |
| src/indentation.rs | Updates indentation tracking to store SpanInfo alongside top-level tokens |
| src/formatter.rs | Implements formatting logic for ReservedNewlineAfter tokens and improves span-based formatting decisions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Just add few more tokens
And also provide better nested inline support.
02e0af9 to
2ab0257
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for more tokens and improves how vertical span mix with horizontal (hopefully)