Skip to content

Remove whitespace-oriented logic#98

Closed
lu-zero wants to merge 8 commits intoshssoichiro:masterfrom
lu-zero:remove-whitespace-oriented-logic
Closed

Remove whitespace-oriented logic#98
lu-zero wants to merge 8 commits intoshssoichiro:masterfrom
lu-zero:remove-whitespace-oriented-logic

Conversation

@lu-zero
Copy link
Copy Markdown
Contributor

@lu-zero lu-zero commented Sep 8, 2025

This is my initial attempt at removing the whitespace-oriented logic, in the process I ended up reworking a bit the token parsing.

In the following days I'll clean it up, but it removes the support for keeping -- comments on the same line. I consider that bringing more problems than it solves, but you tell me :)

@shssoichiro
Copy link
Copy Markdown
Owner

It does seem like this is too large of a behavior change, that if we were to implement this, we would want an option to keep the previous behavior.

@lu-zero
Copy link
Copy Markdown
Contributor Author

lu-zero commented Sep 12, 2025

Agreed.

@lu-zero
Copy link
Copy Markdown
Contributor Author

lu-zero commented Sep 12, 2025

I'm adopting a different approach now.

@lu-zero lu-zero closed this Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants