Skip to content

5.7.2#231

Merged
shub39 merged 11 commits intomasterfrom
dev
Mar 26, 2026
Merged

5.7.2#231
shub39 merged 11 commits intomasterfrom
dev

Conversation

@shub39
Copy link
Copy Markdown
Owner

@shub39 shub39 commented Mar 26, 2026

Summary by CodeRabbit

Release Notes - Version 5.7.2

  • Bug Fixes

    • Fixed Material Theme not working
  • Improvements

    • App updated to version 5.7.2 with improved theming sync (Material You)
    • Share dialog: refined album-art shape indicator coloring
  • Localization

    • Added Polish language support
    • Updated Italian and Korean translations
  • Changelog

    • Changelog updated for 5.7.2

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: eab26274-c860-4752-b75e-a2535675efc0

📥 Commits

Reviewing files that changed from the base of the PR and between 2360134 and 30e07d4.

📒 Files selected for processing (1)
  • app/src/main/assets/changelog.json
✅ Files skipped from review due to trivial changes (1)
  • app/src/main/assets/changelog.json

📝 Walkthrough

Walkthrough

Updated app to v5.7.2: Koin upgraded and switched to compiler plugin usage, Koin ViewModel imports adjusted, Koin startup updated, Material3 expressive API opt-ins and theme wiring modified, Paint handling in Glow changed, Italian/Korean/Polish localizations added/updated, and changelog/version metadata updated.

Changes

Cohort / File(s) Summary
Version & Release
CHANGELOG.md, app/src/main/assets/changelog.json, fastlane/metadata/android/en-US/full_description.txt
Added v5.7.2 changelog entry; updated assets changelog; removed "Batch download lyrics" from Play Store description.
Root Gradle Plugins & Versions
build.gradle.kts, gradle/libs.versions.toml
Added koin.compiler plugin alias; bumped Koin to 4.2.0 and added koin-plugin; updated Kotlin, KSP, Compose, Material3, lifecycle, purchases, and Spotless versions.
App Gradle & Koin deps
app/build.gradle.kts
Applied koin.compiler plugin in app module; bumped app version name/code to 5.7.2 / 5720; replaced KSP-based koin-ksp-compiler usage with implementation(libs.koin.annotations) and removed ksp(...) usage.
Koin Startup / Modules
app/src/main/java/com/shub39/rush/app/RushApplication.kt
Changed Koin initialization to startKoin<RushModules> { ... }, removed explicit modules(...) registration and adjusted imports to plugin DSL.
ViewModel Koin Annotations
app/src/main/java/com/shub39/rush/viewmodels/...VM.kt
GlobalVM.kt, LyricsVM.kt, SavedVM.kt, SearchSheetVM.kt, SettingsVM.kt, ShareVM.kt
Replaced org.koin.android.annotation.KoinViewModel imports with org.koin.core.annotation.KoinViewModel across multiple ViewModels (imports only).
GlobalVM — Theme sync
app/src/main/java/com/shub39/rush/viewmodels/GlobalVM.kt
Added subscription to otherPreferences.getMaterialYouFlow() in startSync() to update _state.theme.materialTheme on emissions.
Compose Material & Share UI
app/src/main/java/com/shub39/rush/presentation/share/component/SharePageSheet.kt
Added ExperimentalMaterial3ExpressiveApi to @OptIn; adjusted album-art-shape indicator coloring to use conditional ToggleButtonDefaults.tonalToggleButtonColors() colors instead of MaterialTheme.colorScheme.onSurface.
Graphics / Paint Handling
app/src/main/java/com/shub39/rush/presentation/Glow.kt
Refactored draw paint usage to access Android Paint via Paint().nativePaint instead of .asFrameworkPaint().
Minor Presentation Note
app/src/main/java/com/shub39/rush/presentation/setting/section/LookAndFeelPage.kt
Inserted a single-line comment // material theme before the Material theme ListItem.
Localization — Italian
app/src/main/res/values-it/strings.xml
Updated max_lines wording; added whats_changed, looks, text, others, show_app_branding.
Localization — Korean
app/src/main/res/values-ko/strings.xml
Fixed grant_permission typo; added ~34 new Korean strings for backup/export/restore, theming, Rush mode, sorting, and UX labels.
Localization — Polish
app/src/main/res/values-pl/strings.xml
Added new Polish localization file with 155 string resources covering UI, search, settings, theming, and feature toggles.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related PRs

  • dev #153 — Changes to Koin initialization and RushApplication startup (both modify Koin startup/module registration).
  • dev #171 — SharePageSheet and album-art-shape handling updates (UI/ToggleButton/coloring changes overlap).
  • 5.7.1 #228 — Release/version artifacts and changelog updates (version bump and changelog entries).

Poem

🐰 A tiny hop, a careful tweak,
Koin now hums a different beat.
Paints go native, colors sing,
New words for Italiano, 한국어, Polski spring.
5.7.2 — a cheeky rabbit's treat! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title '5.7.2' is vague and generic, providing only a version number without conveying any meaningful information about the changeset's purpose or main changes. Replace the title with a descriptive summary of the main change, such as 'Version 5.7.2: Fix Material Theme and upgrade Koin dependencies' or similar to clarify the primary updates.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@app/src/main/java/com/shub39/rush/viewmodels/ShareVM.kt`:
- Line 33: The import for the Koin ViewModel annotation is wrong; replace the
current import of org.koin.core.annotation.KoinViewModel with
org.koin.android.annotation.KoinViewModel so the `@KoinViewModel` annotation used
on the ShareVM class resolves correctly in Koin 4.2.0 (locate the import
statement near the top of ShareVM.kt and update it accordingly).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 18cfc5c8-938a-4371-9567-6307e1dc301b

📥 Commits

Reviewing files that changed from the base of the PR and between 8c62fc3 and 2360134.

📒 Files selected for processing (18)
  • CHANGELOG.md
  • app/build.gradle.kts
  • app/src/main/java/com/shub39/rush/app/RushApplication.kt
  • app/src/main/java/com/shub39/rush/presentation/Glow.kt
  • app/src/main/java/com/shub39/rush/presentation/setting/section/LookAndFeelPage.kt
  • app/src/main/java/com/shub39/rush/presentation/share/component/SharePageSheet.kt
  • app/src/main/java/com/shub39/rush/viewmodels/GlobalVM.kt
  • app/src/main/java/com/shub39/rush/viewmodels/LyricsVM.kt
  • app/src/main/java/com/shub39/rush/viewmodels/SavedVM.kt
  • app/src/main/java/com/shub39/rush/viewmodels/SearchSheetVM.kt
  • app/src/main/java/com/shub39/rush/viewmodels/SettingsVM.kt
  • app/src/main/java/com/shub39/rush/viewmodels/ShareVM.kt
  • app/src/main/res/values-it/strings.xml
  • app/src/main/res/values-ko/strings.xml
  • app/src/main/res/values-pl/strings.xml
  • build.gradle.kts
  • fastlane/metadata/android/en-US/full_description.txt
  • gradle/libs.versions.toml
💤 Files with no reviewable changes (1)
  • fastlane/metadata/android/en-US/full_description.txt

@shub39 shub39 merged commit 4529d6e into master Mar 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants