Skip to content

Setting default checksum file fix #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shubhangi-google wants to merge 2 commits into
base: setting_default_checksum
Choose a base branch
from
Open

Setting default checksum file fix #45

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2143363
closing file
shubhangi-google Oct 15, 2025
7ca57f3
refactor
shubhangi-google Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 20 additions & 10 deletions google-cloud-storage/lib/google/cloud/storage/file/verifier.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,16 @@ def self.md5_for local_file
::Digest::MD5.file(f).base64digest
end
else # StringIO
(local_file = ::File.open Pathname(local_file)) unless local_file.respond_to? :rewind
local_file.rewind
md5 = ::Digest::MD5.base64digest local_file.read
local_file.rewind
md5
file_to_close = nil
file_to_close = local_file = ::File.open(Pathname(local_file).to_path, "rb") unless local_file.respond_to?(:rewind)
begin
local_file.rewind
md5 = ::Digest::MD5.base64digest local_file.read
local_file.rewind
md5
ensure
file_to_close.close if file_to_close.respond_to?(:close) && !file_to_close.closed?
end
end
end

Expand All @@ -69,11 +74,16 @@ def self.crc32c_for local_file
::Digest::CRC32c.file(f).base64digest
end
else # StringIO
(local_file = ::File.open Pathname(local_file)) unless local_file.respond_to? :rewind
local_file.rewind
crc32c = ::Digest::CRC32c.base64digest local_file.read
local_file.rewind
crc32c
file_to_close = nil
file_to_close = local_file = ::File.open(Pathname(local_file).to_path, "rb") unless local_file.respond_to?(:rewind)
begin
local_file.rewind
crc32c = ::Digest::CRC32c.base64digest local_file.read
local_file.rewind
crc32c
ensure
file_to_close.close if file_to_close.respond_to?(:close) && !file_to_close.closed?
end
end
end
end
Expand Down