Chore(storage) : Update move logic now to support non-HNS buckets

[shubhangi-google]

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

• Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea.
• Follow the instructions in CONTRIBUTING. Most importantly, ensure the tests and linter pass by running bundle exec rake ci in the gem subdirectory.
• Update code documentation if necessary.

closes: #<issue_number_goes_here>

[gemini-code-assist]

Summary of Changes

Hello @shubhangi-google, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request broadens the utility of the move_file operation within the Google Cloud Storage Ruby client library. By removing the prior limitation to Hierarchical Namespace (HNS) enabled buckets, the move_file method can now be used with any bucket type, making the storage client more versatile and user-friendly for file management tasks.

Highlights

• Expanded move_file functionality: The move_file operation in the Google Cloud Storage client library now supports all bucket types, removing the previous restriction to only Hierarchical Namespace (HNS) enabled buckets.
• Documentation Update: The documentation for the move_file method has been updated to reflect its broader applicability across all bucket types.
• Enhanced Acceptance Tests: New acceptance tests have been added and existing ones modified to validate the move_file functionality on standard buckets, including tests for successful file movement and proper error handling when source and destination filenames are identical.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the file move logic to support non-HNS buckets, which is a great enhancement. The changes include updating documentation and refactoring existing tests to remove the HNS dependency, as well as adding a new suite of acceptance tests for the move functionality. The changes look good overall. I've left a couple of suggestions to improve the efficiency of the new tests by avoiding the creation of large files when testing argument validation, which should help speed up the test suite.

[shubhangi-google]

/gemini review

[gemini-code-assist]

Code Review

This pull request updates the file move logic to support non-HNS buckets, which is a great enhancement. The changes in the implementation and tests look correct in principle. I've added a few suggestions to improve the robustness of the acceptance tests by verifying file content after the move operation, instead of just checking for file existence. This will provide stronger guarantees that the feature works as intended across all bucket types.

[mahendra-google]

LGTM