small cleanup

Author: cristianoc

CHANGELOG.md

@@ -19,6 +19,7 @@
 #### :house: Internal
 - Use latest compiler for tests. https://github.com/rescript-lang/rescript/pull/7186
 - Added infra to modernise AST: theres' Parsetree, Parsetree0 (legacy), and conversion functions to keep compatibility with PPX. https://github.com/rescript-lang/rescript/pull/7185
+- Ast cleanup: remove exp object and exp unreachable. https://github.com/rescript-lang/rescript/pull/7189
 
 # 12.0.0-alpha.5
 

compiler/ml/parmatch.ml

@@ -2212,7 +2212,7 @@ let check_unused pred casel =
                  (*Format.eprintf "%a@." pretty_val u;*)
                  let pattern, constrs, labels = Conv.conv u in
                  let pattern = {pattern with Parsetree.ppat_loc = q.pat_loc} in
-                 match pred false constrs labels pattern with
+                 match pred constrs labels pattern with
                  | None ->
                    Location.prerr_warning q.pat_loc Warnings.Unreachable_case;
                    Used

compiler/ml/parmatch.mli

@@ -84,8 +84,7 @@ val check_partial_gadt :
   case list ->
   partial
 val check_unused :
-  (bool ->
-  (string, constructor_description) Hashtbl.t ->
+  ((string, constructor_description) Hashtbl.t ->
   (string, label_description) Hashtbl.t ->
   Parsetree.pattern ->
   pattern option) ->

compiler/ml/typecore.ml

@@ -1750,14 +1750,9 @@ let check_partial ?(lev = get_current_level ()) env expected_ty loc cases =
 
 let check_unused ?(lev = get_current_level ()) env expected_ty cases =
   Parmatch.check_unused
-    (fun refute constrs labels spat ->
-      match
-        partial_pred ~lev ~mode:Split_or ~explode:5 env expected_ty constrs
-          labels spat
-      with
-      | Some pat when refute ->
-        raise (Error (spat.ppat_loc, env, Unrefuted_pattern pat))
-      | r -> r)
+    (fun constrs labels spat ->
+      partial_pred ~lev ~mode:Split_or ~explode:5 env expected_ty constrs labels
+        spat)
     cases
 
 let add_pattern_variables ?check ?check_as env =