Force content to overflow containing div and not be hidden#371
Open
abeverley wants to merge 1 commit intoshutterstock:mainfrom
Open
Force content to overflow containing div and not be hidden#371abeverley wants to merge 1 commit intoshutterstock:mainfrom
abeverley wants to merge 1 commit intoshutterstock:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This might be me doing something wrong, but I have found that when displaying a y-axis in a separate div, that the content does not display correctly unless the containing div's height is tall enough for the axis labels (the div does not expand to the content). Whilst I could specify the containing div's height (to be the same as the graph), it would be better if that wasn't necessary.
You can see the problem here: http://jsfiddle.net/SSkHD/ (this is based on the main y-axis example, except I have removed the absolute div positioning).
This seems to be because an overflow:hidden is being inherited from somewhere (I couldn't work out where - it's not the svg block). I have found that adding overflow:visible to .rickshaw_graph works (as per this pull request), but I'm not sure whether this will adversely affect anything else. Removing the overflow:hidden from ".rickshaw_graph svg" does not work, and I assume that is there for a reason anyway).
Thanks,
Andy