Move the x_label below the item detail label if they overlap near the top of the chart#502
Open
paulcadman wants to merge 1 commit intoshutterstock:mainfrom
Open
Move the x_label below the item detail label if they overlap near the top of the chart#502paulcadman wants to merge 1 commit intoshutterstock:mainfrom
paulcadman wants to merge 1 commit intoshutterstock:mainfrom
Conversation
… top of the chart. Fixes: shutterstock#482
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #482
It might seem more consistent to position the x_label above the detail label. However an overlap will happen near the top of the chart so this would position the x_label outside the bounds of the chart. There is likely more space below the detail label.