Skip to content

Fix missing language translations causing onboarding crash#68

Closed
spartanz51 wants to merge 3 commits intosiacentral:masterfrom
spartanz51:fix/translation-language-section-missing
Closed

Fix missing language translations causing onboarding crash#68
spartanz51 wants to merge 3 commits intosiacentral:masterfrom
spartanz51:fix/translation-language-section-missing

Conversation

@spartanz51
Copy link
Contributor

No description provided.

@n8mgr
Copy link
Contributor

n8mgr commented Jul 21, 2025

Missing translations should default to English already:

if (!group) {
if (language !== 'en') {
const args = Array.from(arguments);
args[1] = 'en';
return translate.apply(this, args);
}
throw new Error(`unknown translation for ${id.join(', ')}`);
}

@spartanz51 spartanz51 force-pushed the fix/translation-language-section-missing branch from 5bd99e0 to 19b3fa8 Compare July 21, 2025 18:32
@spartanz51
Copy link
Contributor Author

yep but changing language triggers an immediate re-render. it seems that some components render before their data is loaded, so we got undefined parameters (where my guard seems to handle it, but it's a hack)
But imo yes, using i18n will be the real solution here, and more maintenable than the custom translation

@spartanz51 spartanz51 closed this Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants