Fix missing language translations causing onboarding crash#68
Closed
spartanz51 wants to merge 3 commits intosiacentral:masterfrom
Closed
Fix missing language translations causing onboarding crash#68spartanz51 wants to merge 3 commits intosiacentral:masterfrom
spartanz51 wants to merge 3 commits intosiacentral:masterfrom
Conversation
Contributor
|
Missing translations should default to English already: sia-lite-wallet-web/src/translation/index.js Lines 47 to 57 in 4eb150f |
5bd99e0 to
19b3fa8
Compare
Contributor
Author
|
yep but changing language triggers an immediate re-render. it seems that some components render before their data is loaded, so we got undefined parameters (where my guard seems to handle it, but it's a hack) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.