Open
Conversation
Macros AggInfoColumnReg and AggInfoFuncReg use both a comma separated statement where the first statement is an assert(). With NDEBUG this generates no code and compilers will error as the first statement is not valid anymore.
|
I have tested the repo this PR is based on. I found no issues on FATFS. |
smitkant
added a commit
to smitkant/esp32-idf-sqlite3
that referenced
this pull request
Oct 10, 2024
picked from PR - siara-cc#30 and another fork - https://github.com/Higeco/esp32-idf-sqlite3/tree/upgrade_to_3.46.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR upgrades SQLite to 3.46.0. I've done some initial tests (using the examples) and all works pretty fine, but of course it needs a bit more testing and maybe performance may vary depending on personal use case. In case, if it was not your intention to follow upstream versions (but yeah, 3.25.1 is rather old ;) ), it could just remain here as an open MR and who is interested could profit from there.
Note: besides the bump of the sqlite amalgamation there is a small fix for the build with NDEBUG. I've kept the commits intentionally separate to explicit this.