Skip to content

Fix GROUP BY spacing in semantic expansion #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nicosuave wants to merge 6 commits into from
Closed

Fix GROUP BY spacing in semantic expansion #17

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7c39936
Fix AGGREGATE expansion in CTEs
nicosuave Jan 9, 2026
1b45909
Fix CI compile error
nicosuave Jan 9, 2026
0f1f4ca
Handle spacing in GROUP BY parsing
nicosuave Jan 9, 2026
4ab83db
Handle GROUP BY spacing
nicosuave Jan 9, 2026
0beb011
Add GROUP BY spacing view test
nicosuave Jan 9, 2026
db3117a
Merge origin/main
nicosuave Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions test/sql/measures.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,51 @@ SEMANTIC SELECT year, region, AGGREGATE(revenue) FROM sales_v;
2023 EU 75.0
2023 US 150.0

# =============================================================================
# Test: CTE with AGGREGATE
# =============================================================================

query IIR rowsort
SEMANTIC WITH a AS (
SELECT year, region, AGGREGATE(revenue) AS revenue
FROM sales_v
)
SELECT * FROM a;
----
2022 EU 50.0
2022 US 100.0
2023 EU 75.0
2023 US 150.0

# =============================================================================
# Test: GROUP BY with extra spaces
# =============================================================================

statement ok
CREATE VIEW sales_grouped AS
SELECT year, region, SUM(amount) AS MEASURE revenue
FROM sales
GROUP BY year, region;

query IIR rowsort
SEMANTIC SELECT year, region, AGGREGATE(revenue) AT (ALL region) AS year_total
FROM sales_grouped;
----
2022 EU 150.0
2022 US 150.0
2023 EU 225.0
2023 US 225.0

query IIR rowsort
SEMANTIC SELECT year, region, AGGREGATE(revenue) AT (ALL region) AS year_total
FROM sales_v
GROUP BY year, region;
----
2022 EU 150.0
2022 US 150.0
2023 EU 225.0
2023 US 225.0

# =============================================================================
# Test: AT (ALL dimension) - remove dimension from context
# =============================================================================
Expand Down
Loading
Loading