-
Notifications
You must be signed in to change notification settings - Fork 34
feat: upgrade to CAPI v1.11.x #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: upgrade to CAPI v1.11.x #228
Conversation
6ffe030
to
3f13a66
Compare
Upgrading the `cluster-api` version from `v1.10.4` to `v1.11.1` with underlying changes to Talos specific configs, same logic as before. Signed-off-by: Steffen Karlsson <[email protected]>
3f13a66
to
40fe7cd
Compare
The ![]() |
Working on a similar PR for https://github.com/siderolabs/cluster-api-control-plane-provider-talos, but as Control Plane Provider is depending on Bootstrap Provider, it cannot be completed, before this one is merged and release due to incompatibility of |
Signed-off-by: Steffen Karlsson <[email protected]>
Signed-off-by: Steffen Karlsson <[email protected]>
I really appreciate your effort, but this would make CABPT incompatible with CAPI core <= 1.11, so we need to take this slowly. |
I understand @smira, do you rather want to evolve the api version to i.e. |
No, I don't think we need to change CABPT CRDs, I mean the following:
|
I'm not sure thats the case, at least what we have observed and tested so far. Unfortunately we see that bootstrap and control plane provider are no longer working and this is because of breaking changes in Example: Those two are incompatible and it does not work to do a in-place replacement for that dependency as you can do for Please let me know what you think @smira |
What exactly is not the case? CAPI 1.x should have backwards compatibility |
From a programming perspective, |
This is source code compatibility, not API-level. |
Yes sorry, should have been more specific on source code compatibility. |
Upgrading the
cluster-api
version fromv1.10.4
tov1.11.1