feat: add imagefactory docker compose example#58
feat: add imagefactory docker compose example#58fsgh42 wants to merge 2 commits intosiderolabs:mainfrom
Conversation
| SCHEMATICS_SLEEP_TIME=600 | ||
|
|
||
| IMGFAC_VERSION=v0.5.0 | ||
| IMGFAC_EXTERNAL_URL=imgfac.example.com |
There was a problem hiding this comment.
this should be a proper URL (when passed as an argument), this might be the reason the UI doesn't work properly, e.g. http://imgfac.example.com/
There was a problem hiding this comment.
I'd argue since no reverse-proxy is part of this scenario, we can assume it is always http.
See 9d937af
| crane push \ | ||
| --insecure \ | ||
| ${TMP_FILE} \ | ||
| ${REGISTRY_URL}/installer/${SCHEMA_ID}:${TALOS_VERSION} |
There was a problem hiding this comment.
I'm not sure why this is needed, Image Factory itself can work as a container registry (to pull installer images from)?
There was a problem hiding this comment.
I don't really remember to be honest. I wrote this code some while ago and I wasn't aware the registry I added here is actually not needed, I thought imagefactory needs this as a companion, it made sense in my head I guess.
Do you want me to remove the external registry (called registry in docker-compose.yaml) and related code?
There was a problem hiding this comment.
This registry should be there, but there's no need to push anything there. All I'm asking is to remove this file completely, as it's not needed
fsgh42
force-pushed
the
imagefactory-compose
branch
from
9d937af to
33556f4
Compare
|
|
||
| ## URLs not working | ||
|
|
||
| There is a tiny problem in the `imagefactory` frontend: The URLs generated contain the external domain used and it is duplicated for some reason. This is particularly mean because the URL _visible_ in the UI looks correct, but the `HTML` `href` is not. |
There was a problem hiding this comment.
I guess this should be fixed is the proper URL (with http:// is passed)
2 participants
This code deploys
sideroimagefactory in a localdocker composesetup.It leaves out TLS, but deploys an upstream
ghcr.iomirror and anotherregistrythat generated images are pushed to. It also ships a tiny script that generates images from predefined schemas.see
README.mdfor more details.related slack message