fix: add /usr/bin symlinks for nvidia-ctk and nvidia-cdi-hook#1019
Closed
ormandj wants to merge 1 commit intosiderolabs:mainfrom
Closed
fix: add /usr/bin symlinks for nvidia-ctk and nvidia-cdi-hook#1019ormandj wants to merge 1 commit intosiderolabs:mainfrom
ormandj wants to merge 1 commit intosiderolabs:mainfrom
Conversation
The gpu-operator device plugin generates CDI specs with hooks pointing to /usr/bin/nvidia-ctk and /usr/bin/nvidia-cdi-hook (hardcoded defaults in NVIDIA/k8s-device-plugin and NVIDIA/nvidia-container-toolkit). Talos extensions install these binaries under /usr/local/bin/, causing pods requesting nvidia.com/gpu resource limits to fail. Add symlinks from /usr/bin/nvidia-ctk and /usr/bin/nvidia-cdi-hook to their /usr/local/bin/ counterparts, following the same pattern as the existing /usr/bin/ldconfig symlink. This eliminates the need for users to set NVIDIA_CDI_HOOK_PATH in the gpu-operator values. Requires siderolabs/talos#13021 validator allowlist update. Signed-off-by: David Orman <ormandj@corenode.com>
ormandj
force-pushed
the
fix/nvidia-cdi-hook-symlinks
branch
from
6e2c82d to
72e89c3
Compare
Member
|
Thank you, went with symlink approach in siderolabs/talos#13022 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What? (description)
Adds symlinks from
/usr/bin/nvidia-ctk→/usr/local/bin/nvidia-ctkand/usr/bin/nvidia-cdi-hook→/usr/local/bin/nvidia-cdi-hookin the nvidia-container-toolkit extension build.Why? (reasoning)
The gpu-operator device plugin generates CDI specs with hooks pointing to
/usr/bin/nvidia-ctk(DefaultNvidiaCTKPath) and/usr/bin/nvidia-cdi-hook(defaultNvidiaCDIHookPath). Talos extensions install these binaries under/usr/local/bin/, so pods requestingnvidia.com/gpuresource limits fail with a "no such file" error.This follows the exact pattern of the existing
/usr/bin/ldconfigsymlink. With these symlinks, the device plugin's default CDI hook paths resolve correctly and users no longer need to setNVIDIA_CDI_HOOK_PATHin their gpu-operator values.Depends on: siderolabs/talos#13022 (validator allowlist update to permit
/usr/bin/nvidia-ctkand/usr/bin/nvidia-cdi-hook)Ref: siderolabs/talos#13021