fix the type of ResultSetHeader **insertId** attribute type#1267
Open
buuug7 wants to merge 1 commit intosidorares:masterfrom
buuug7:master
Open
fix the type of ResultSetHeader **insertId** attribute type#1267buuug7 wants to merge 1 commit intosidorares:masterfrom buuug7:master
buuug7 wants to merge 1 commit intosidorares:masterfrom
buuug7:master
Conversation
database table ID either **number** or **string**
Contributor
|
Nope. LastInsertId has to be number. https://dev.mysql.com/doc/internals/en/packet-OK_Packet.html |
Owner
|
when |
Contributor
|
ah I forgot |
Owner
|
I'm not a fan of this polymorphic results but not quite sure how to improve ( and in backwards compatible way ) we can probably retire Long.js and return native BigInt here so the type will be |
wellwelwel
added
typescript
needs rebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
database table ID either number or string