declutter promise typing for query() and execute()#1371
Open
mxw wants to merge 1 commit intosidorares:masterfrom
Open
declutter promise typing for query() and execute()#1371mxw wants to merge 1 commit intosidorares:masterfrom
mxw wants to merge 1 commit intosidorares:masterfrom
Conversation
the overloading makes the function types harder to work with and adds no type refinement value. prefer a single, more concise interface.
this commit leaves the `any | any[] | { [param: string]: any }` typing for documentation benefits, even though it's identical to just `any`.
wellwelwel
added
typescript
needs discussion
needs rebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the overloading makes the function types harder to work with and adds no type refinement value. prefer a single, more concise interface.
this commit leaves the
any | any[] | { [param: string]: any }typing for documentation benefits, even though it's identical to justany.