Skip to content

fix(cache): improve cache key serialization #2424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 26, 2024
Merged

fix(cache): improve cache key serialization #2424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dd04890
fix(cache): improve cache key formation
wellwelwel Jan 31, 2024
4c3b0c0
ci: add tests to sanitize cache key helper
wellwelwel Jan 31, 2024
8dafb2b
refactor: change serialization to `JSON.stringify`
wellwelwel Jan 31, 2024
4009911
ci: add tests to cache key serialization
wellwelwel Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 28 additions & 15 deletions lib/parsers/parser_cache.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,26 +3,38 @@
const LRU = require('lru-cache').default;

const parserCache = new LRU({
max: 15000
max: 15000,
});

function keyFromFields(type, fields, options, config) {
let res =
`${type}` +
`/${typeof options.nestTables}` +
`/${options.nestTables}` +
`/${options.rowsAsArray}` +
`/${options.supportBigNumbers || config.supportBigNumbers}` +
`/${options.bigNumberStrings || config.bigNumberStrings}` +
`/${typeof options.typeCast}` +
`/${options.timezone || config.timezone}` +
`/${options.decimalNumbers}` +
`/${options.dateStrings}`;
const res = [
type,
typeof options.nestTables,
options.nestTables,
Boolean(options.rowsAsArray),
Boolean(options.supportBigNumbers || config.supportBigNumbers),
Boolean(options.bigNumberStrings || config.bigNumberStrings),
typeof options.typeCast,
options.timezone || config.timezone,
Boolean(options.decimalNumbers),
options.dateStrings,
];

for (let i = 0; i < fields.length; ++i) {
const field = fields[i];
res += `/${field.name}:${field.columnType}:${field.length}:${field.schema}:${field.table}:${field.flags}:${field.characterSet}`;

res.push([
field.name,
field.columnType,
field.length,
field.schema,
field.table,
field.flags,
field.characterSet,
]);
}
return res;

return JSON.stringify(res, null, 0);
}

function getParser(type, fields, options, config, compiler) {
Expand All @@ -49,5 +61,6 @@ function clearCache() {
module.exports = {
getParser: getParser,
setMaxCache: setMaxCache,
clearCache: clearCache
clearCache: clearCache,
_keyFromFields: keyFromFields,
};
Loading