Skip to content

fix: fix wrong length number write to packet #3177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: fix wrong length number write to packet #3177

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2392e3c
fix: fix wrong length number write to packet
Nov 1, 2024
af69213
Merge branch 'master' into bugfix/fix-big-data-stmt
wellwelwel Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions lib/packets/packet.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -832,11 +832,10 @@
if (n === null) {
return this.writeInt8(0xfb);
}
// TODO: check that n is out of int precision
this.writeInt8(0xfe);
this.buffer.writeUInt32LE(n, this.offset);
this.buffer.writeUInt32LE(n & 0xffffffff, this.offset);

Check warning on line 836 in lib/packets/packet.js

View check run for this annotation

Codecov / codecov/patch

lib/packets/packet.js#L836 

Added line #L836 was not covered by tests
this.offset += 4;
this.buffer.writeUInt32LE(n >> 32, this.offset);
this.buffer.writeUInt32LE(Math.floor(n / 0x100000000), this.offset);

Check warning on line 838 in lib/packets/packet.js

View check run for this annotation

Codecov / codecov/patch

lib/packets/packet.js#L838 

Added line #L838 was not covered by tests
this.offset += 4;
return this.offset;
}
Expand Down
Loading