refactor: upgrade ESLint and migrate its plugins to v9#3456
Merged
wellwelwel merged 1 commit intosidorares:masterfrom Mar 5, 2025
Merged
refactor: upgrade ESLint and migrate its plugins to v9#3456wellwelwel merged 1 commit intosidorares:masterfrom
v9#3456wellwelwel merged 1 commit intosidorares:masterfrom
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
Collaborator
Author
|
I also took care to check each PR opened one by one: From 49 valid PRs (not bots):
I carefully create a label for each of them, which is where each link above leads. The recent #3451 PR was not impacted ✨ |
v9v9
v9v9
This was referenced Mar 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no change in the actual files, except for ESLint applying the auto fixes, including Prettier's rules (nothing else), while migrating ESLint and its respective plugins to their latest versions.
For years,
lint-stagenever performed formatting before commits, which is why so many files were affected. I'll open a separate PR removing this dependency since it's not actually used in practice.Also, you can follow all breaking changes from ESLint in Migrate to v9.x documentation.
CodeQL
It's interesting to note that CodeQL will notify about two warnings, since a comma has been removed from the line in question for each warning.
If this is indeed a problem to be addressed, I don't see this PR as the ideal place for it, since it's exclusively for lint and format rules and its apply.