test: add SQL formatting tests#4052
Merged
wellwelwel merged 5 commits intosidorares:masterfrom Feb 4, 2026
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
wellwelwel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1247.
In sqlstring, it skips formatting fornullparams invalues, but proceeds with the logic forundefined.This PR skips the formatting forundefinedin thevaluesparameter.Edit: I just noticed the double operator for
null((undefined == null) === true).#4051 mentions a blog that shows a potential vulnerability that can be resolved by a workaround, forcing the
stringifyObjectsoption totrue.The new test proves this and also confirms that #1247 has been resolved over time.
Note
This PR doesn't cover the bug reported in #4051, but it serves as a precursor by recognizing the reported error and preparing tests for the subsequent fix for this matter.