Skip to content

refactor(buttons): use square buttons instead of circle in layout/nav components #1358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spike-rabbit merged 1 commit into from
Jan 23, 2026
Merged

refactor(buttons): use square buttons instead of circle in layout/nav components #1358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions projects/element-ng/electron-titlebar/si-electron-titlebar.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
>
<button
type="button"
class="btn btn-circle btn-sm btn-tertiary"
class="btn btn-icon btn-sm btn-tertiary"
[class.unfocused]="!hasFocus()"
[attr.aria-label]="ariaLabelBack() | translate"
[disabled]="!canGoBack()"
Expand All @@ -17,7 +17,7 @@
</button>
<button
type="button"
class="btn btn-circle btn-sm btn-tertiary"
class="btn btn-icon btn-sm btn-tertiary"
[class.unfocused]="!hasFocus()"
[attr.aria-label]="ariaLabelForward() | translate"
[disabled]="!canGoForward()"
Expand All @@ -28,7 +28,7 @@
@if (menuItems().length > 0) {
<button
type="button"
class="btn btn-circle electron-title-bar-btn btn-tertiary btn-sm"
class="btn btn-icon electron-title-bar-btn btn-tertiary btn-sm"
[class.unfocused]="!hasFocus()"
[attr.aria-label]="ariaLabelMenu() | translate"
[cdkMenuTriggerFor]="menu"
Expand Down
2 changes: 1 addition & 1 deletion projects/element-ng/navbar-vertical/si-navbar-vertical.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<div class="mobile-drawer focus-inside navbar-vertical-no-collapse">
<button
type="button"
class="btn btn-circle btn-ghost"
class="btn btn-icon btn-ghost"
[attr.aria-label]="
(collapsed() ? navbarExpandButtonText() : navbarCollapseButtonText()) | translate
"
Expand Down
10 changes: 5 additions & 5 deletions projects/element-ng/side-panel/si-side-panel-content.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
@if (displayMode() === 'navigate' && navigateConfig) {
@if (navigateConfig.type === 'router-link') {
<a
class="btn btn-circle btn-ghost auto-hide"
class="btn btn-icon btn-ghost auto-hide"
[class.ms-4]="collapsible()"
[class.mx-4]="!collapsible() || service.isTemporaryOpen()"
[routerLink]="navigateConfig.routerLink"
Expand All @@ -35,7 +35,7 @@
>
} @else if (navigateConfig.type === 'link') {
<a
class="btn btn-circle btn-ghost auto-hide"
class="btn btn-icon btn-ghost auto-hide"
[class.ms-4]="collapsible()"
[class.mx-4]="!collapsible()"
[href]="navigateConfig.href"
Expand All @@ -53,7 +53,7 @@
@if (displayMode() === 'overlay') {
<button
type="button"
class="fullscreen-button btn btn-circle btn-ghost auto-hide"
class="fullscreen-button btn btn-icon btn-ghost auto-hide"
[class.ms-4]="collapsible()"
[class.mx-4]="!collapsible() || service.isTemporaryOpen()"
[attr.aria-label]="
Expand All @@ -67,7 +67,7 @@
}
<button
type="button"
class="close-button btn btn-circle btn-ghost me-4"
class="close-button btn btn-icon btn-ghost me-4"
[attr.aria-label]="closeButtonLabel() | translate"
[tabindex]="focusable() ? '0' : '-1'"
(click)="toggleSidePanel($event)"
Expand All @@ -77,7 +77,7 @@
<div class="collapse-toggle">
<button
type="button"
class="side-panel-collapse-toggle btn btn-circle btn-ghost mx-4"
class="side-panel-collapse-toggle btn btn-icon btn-ghost mx-4"
[attr.aria-label]="toggleItemLabel() | translate"
(click)="toggleSidePanel($event)"
>
Expand Down
4 changes: 2 additions & 2 deletions src/app/examples/si-list-details/si-list-details.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
/>
<button
type="button"
class="btn btn-circle btn-tertiary"
class="btn btn-icon btn-tertiary"
aria-label="Options"
[cdkMenuTriggerFor]="contextMenu"
>
Expand All @@ -38,7 +38,7 @@
/>
<button
type="button"
class="btn btn-circle btn-ghost element-filter me-2"
class="btn btn-icon btn-ghost element-filter me-2"
aria-label="Filters"
(click)="logEvent('Filters')"
></button>
Expand Down
Loading