feat(launchpad): add arial-label for favorite icons #1360
Conversation
Summary of ChangesHello @dauriamarco, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the accessibility of the launchpad's favorite functionality. By implementing dynamic Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request successfully adds aria-label attributes to the favorite icons in the launchpad, enhancing accessibility. The new translatable keys SI_LAUNCHPAD.ADD_FAVORITE and SI_LAUNCHPAD.REMOVE_FAVORITE are correctly introduced in the SiTranslatableKeys interface and utilized in the si-launchpad-app.component.html and si-launchpad-app.component.ts files. The implementation is clean and directly addresses the feature described in the PR title and body. No issues were found.
|
Documentation. Coverage Reports: |
dauriamarco
force-pushed
the
fix/lauchpad-fav-label
branch
from
cae4fec to
9d184da
Compare
dauriamarco
force-pushed
the
fix/lauchpad-fav-label
branch
from
9d184da to
9584b1f
Compare
|
|
spliffone
left a comment
spliffone
left a comment
There was a problem hiding this comment.
@dauriamarco @spike-rabbit Do we have any chance to separate the App name, System name and the favorite aria label in the accessibility tree?
| * t(() => $localize`:@@SI_LAUNCHPAD.REMOVE_FAVORITE:Remove from favorites`) | ||
| * ``` | ||
| */ | ||
| readonly removeFavoriteText = input<TranslatableString>( |
There was a problem hiding this comment.
| readonly removeFavoriteText = input<TranslatableString>( | |
| readonly removeFavoriteText = input( |
| * t(() => $localize`:@@SI_LAUNCHPAD.ADD_FAVORITE:Add to favorites`) | ||
| * ``` | ||
| */ | ||
| readonly addFavoriteText = input<TranslatableString>( |
There was a problem hiding this comment.
I guess the type is unneccessary since you use the t()function.
| readonly addFavoriteText = input<TranslatableString>( | |
| readonly addFavoriteText = input( |
|
I think the overall accessible behavior is broken. But I have no idea how to do it correct. I will contact the a11y guys. |
Adds arial-labels for favorite action in the launchpad items.