refactor(chat-messages): migrate to svg icons#1465
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request successfully migrates the chat message components to use SVG icons, which is a great improvement. The changes are consistent across all affected components and their tests. I have one minor suggestion in the si-chat-input.component.spec.ts file to improve the robustness of a test by using a more specific selector, making it consistent with other updated tests in the same file.
projects/element-ng/chat-messages/si-chat-input.component.spec.ts
Outdated
Show resolved
Hide resolved
spliffone
force-pushed
the
refactor/chat-messages-svg-icons
branch
from
0f14ee3 to
e13708b
Compare
spliffone
force-pushed
the
refactor/chat-messages-svg-icons
branch
from
e13708b to
48488ac
Compare
|
|
|
Documentation. Coverage Reports: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.