build(npm): use correct override for @simpl/brand#1467
Merged
Conversation
We previously just accepted a broad range, which did not cover `-rc.x` release. So npm failed when doing a release. The new override is pointing the local package instead, which solves the problem.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the package.json to correctly override the @siemens/element-theme dependency for @simpl/brand. Changing the override from a version range (>1.0.0) to a local file path (file:projects/element-theme) is the correct approach in this monorepo context. It ensures that the local workspace package is used, which resolves the build failures with pre-release versions as described. The change is sound and I have no suggestions for improvement.
|
|
|
Documentation. Coverage Reports: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We previously just accepted a broad range,
which did not cover
-rc.xrelease.So npm failed when doing a release.
The new override is pointing the local package instead, which solves the problem.