Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the si-filter-pill component to use the new si-icon component for displaying the remove icon, replacing the old CSS-based approach. The changes are correct and well-implemented. The necessary imports and component updates in si-filter-pill.component.ts are done correctly, and the template in si-filter-pill.component.html is updated accordingly. The snapshot tests have also been updated to reflect the visual changes, which is good practice. Overall, this is a solid refactoring that improves consistency with the new icon system.
|
Documentation. Coverage Reports: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.