Skip to content

refactor(filter-bar): migrate to svg icons#1468

Open
spliffone wants to merge 1 commit intomainfrom
refactor/filter-bar-svg-icons
Open

refactor(filter-bar): migrate to svg icons#1468
spliffone wants to merge 1 commit intomainfrom
refactor/filter-bar-svg-icons

Conversation

@spliffone
Copy link
Member

@spliffone spliffone commented Feb 6, 2026

Describe in detail what your merge request does and why. Add relevant
screenshots and reference related issues via Closes #XY or Related to #XY.


@spliffone spliffone requested review from a team as code owners February 6, 2026 10:02
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the si-filter-pill component to use the new si-icon component for displaying the remove icon, replacing the old CSS-based approach. The changes are correct and well-implemented. The necessary imports and component updates in si-filter-pill.component.ts are done correctly, and the template in si-filter-pill.component.html is updated accordingly. The snapshot tests have also been updated to reflect the visual changes, which is good practice. Overall, this is a solid refactoring that improves consistency with the new icon system.

@github-actions
Copy link

github-actions bot commented Feb 6, 2026

Code Coverage

@github-actions
Copy link

github-actions bot commented Feb 6, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant