Skip to content

feat(filter-bar): provide translatable remove button label#1469

Open
spliffone wants to merge 1 commit intomainfrom
refactor/filter-bar-remove-button-label
Open

feat(filter-bar): provide translatable remove button label#1469
spliffone wants to merge 1 commit intomainfrom
refactor/filter-bar-remove-button-label

Conversation

@spliffone
Copy link
Member

@spliffone spliffone commented Feb 6, 2026

Describe in detail what your merge request does and why. Add relevant
screenshots and reference related issues via Closes #XY or Related to #XY.


@spliffone spliffone requested a review from a team as a code owner February 6, 2026 10:24
@spliffone spliffone added this to the 49.0.0 milestone Feb 6, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new translatable property removeButtonLabel for the remove button in the filter bar, enhancing internationalization capabilities. The implementation is well-executed across the components and templates. My only finding is a minor inconsistency in the API golden file for translations, which I've commented on. Once that is addressed, this change looks good to merge.

// (undocumented)
'SI_FILTER_BAR.NO_FILTERS'?: string;
// (undocumented)
'SI_FILTER_BAR.REMOVE_BUTTON_LABEL'?: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

There's an inconsistency in the translation key used in the API golden file. This key is defined as 'SI_FILTER_BAR.REMOVE_BUTTON_LABEL', but other files in this PR, such as si-translatable-keys.interface.ts and the components themselves, use 'SI_FILTER_BAR.REMOVE_LABEL'. Please update this to 'SI_FILTER_BAR.REMOVE_LABEL' to maintain consistency and ensure the API documentation is accurate.

Suggested change
'SI_FILTER_BAR.REMOVE_BUTTON_LABEL'?: string;
'SI_FILTER_BAR.REMOVE_LABEL'?: string;

@github-actions
Copy link

github-actions bot commented Feb 6, 2026

@spliffone spliffone force-pushed the refactor/filter-bar-remove-button-label branch from b632e4b to d17f0e5 Compare February 6, 2026 10:58
@github-actions
Copy link

github-actions bot commented Feb 6, 2026

Code Coverage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant