feat(filter-bar): provide translatable remove button label#1469
feat(filter-bar): provide translatable remove button label#1469
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a new translatable property removeButtonLabel for the remove button in the filter bar, enhancing internationalization capabilities. The implementation is well-executed across the components and templates. My only finding is a minor inconsistency in the API golden file for translations, which I've commented on. Once that is addressed, this change looks good to merge.
| // (undocumented) | ||
| 'SI_FILTER_BAR.NO_FILTERS'?: string; | ||
| // (undocumented) | ||
| 'SI_FILTER_BAR.REMOVE_BUTTON_LABEL'?: string; |
There was a problem hiding this comment.
There's an inconsistency in the translation key used in the API golden file. This key is defined as 'SI_FILTER_BAR.REMOVE_BUTTON_LABEL', but other files in this PR, such as si-translatable-keys.interface.ts and the components themselves, use 'SI_FILTER_BAR.REMOVE_LABEL'. Please update this to 'SI_FILTER_BAR.REMOVE_LABEL' to maintain consistency and ensure the API documentation is accurate.
| 'SI_FILTER_BAR.REMOVE_BUTTON_LABEL'?: string; | |
| 'SI_FILTER_BAR.REMOVE_LABEL'?: string; |
|
Documentation. Coverage Reports: |
b632e4b to
d17f0e5
Compare
Uh oh!
There was an error while loading. Please reload this page.