Skip to content

test: remove karma / jasmine#1733

Merged
spike-rabbit merged 1 commit intomainfrom
test/vitest-cleanup-jasmine
Mar 25, 2026
Merged

test: remove karma / jasmine#1733
spike-rabbit merged 1 commit intomainfrom
test/vitest-cleanup-jasmine

Conversation

@spliffone
Copy link
Member

@spliffone spliffone commented Mar 24, 2026

@spliffone spliffone requested review from a team as code owners March 24, 2026 17:12
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the project's testing infrastructure by removing Karma and Jasmine configurations and dependencies, including the deletion of karma.conf.js and tsconfig.spec.json files, and related entries in package.json. It also standardizes and enhances test coverage reporting for multiple Angular libraries (element-ng, element-translate-ng, charts-ng, native-charts-ng, maps-ng, dashboards-ng) within angular.json, setting specific thresholds, includes, excludes, and reporters (cobertura, html, text). A review comment highlights that the removal of the exports field for docs.json in projects/charts-ng/package.json might be a breaking change and appears out of scope for a test runner migration, suggesting it either be documented or reverted.

I am having trouble creating individual review comments. Click here to see my feedback.

projects/charts-ng/package.json (25-29)

medium

The removal of the exports field for docs.json could be a breaking change for consumers of the charts-ng package. This change appears to be out of scope for a pull request focused on migrating the test runner from Karma/Jasmine. If this removal is intentional, please consider documenting this breaking change. If it's unintentional, it should be reverted.

@spliffone spliffone force-pushed the test/vitest-cleanup-jasmine branch 3 times, most recently from 80d68bc to 44df39f Compare March 24, 2026 19:02
@spliffone spliffone force-pushed the test/vitest-cleanup-jasmine branch from 44df39f to 5123963 Compare March 25, 2026 05:50
Copy link
Member

@spike-rabbit spike-rabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@spike-rabbit spike-rabbit added this pull request to the merge queue Mar 25, 2026
Merged via the queue into main with commit 417208b Mar 25, 2026
11 checks passed
@spike-rabbit spike-rabbit deleted the test/vitest-cleanup-jasmine branch March 25, 2026 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants