Conversation
There was a problem hiding this comment.
Code Review
This pull request migrates the project's testing infrastructure by removing Karma and Jasmine configurations and dependencies, including the deletion of karma.conf.js and tsconfig.spec.json files, and related entries in package.json. It also standardizes and enhances test coverage reporting for multiple Angular libraries (element-ng, element-translate-ng, charts-ng, native-charts-ng, maps-ng, dashboards-ng) within angular.json, setting specific thresholds, includes, excludes, and reporters (cobertura, html, text). A review comment highlights that the removal of the exports field for docs.json in projects/charts-ng/package.json might be a breaking change and appears out of scope for a test runner migration, suggesting it either be documented or reverted.
I am having trouble creating individual review comments. Click here to see my feedback.
projects/charts-ng/package.json (25-29)
The removal of the exports field for docs.json could be a breaking change for consumers of the charts-ng package. This change appears to be out of scope for a pull request focused on migrating the test runner from Karma/Jasmine. If this removal is intentional, please consider documenting this breaking change. If it's unintentional, it should be reverted.
80d68bc to
44df39f
Compare
44df39f to
5123963
Compare
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: