Open
Conversation
…ove parameter validation
Contributor
Author
|
Please don't merge this PR without proper testing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 What is the current behavior?
The current JavaScript and C# interop classes contain significant code duplication and inconsistent patterns:
JavaScript Issues:
C# Issues:
BaseInterop.cs,FileUploadInterop.cs,TabsInterop.cs) contain repeated patterns for module loading, disposal, validation, and error handlingThis leads to:
🆕 What is the new behavior?
JavaScript Improvements:
index.jswith improved AG Grid and ECharts integration safetyC# Improvements:
BaseJSInteropabstract base class that centralizes all common JavaScript interop functionalityBaseJSInterop, eliminating code duplicationDotNetObjectReferencemanagement with proper disposal patternsFiles refactored:
JavaScript files:
categoryFilterInterop.js- Added validation, error handling, and documentationbaseJsInterop.js- Enhanced error handling and input validationapplicationInterop.js- Improved error handling and validationaboutMenuInterop.js- Added comprehensive error handling and validationdateDropdownInterop.js- Enhanced with validation and documentationfileUploadInterop.js- Improved error handling and input validationsettingsMenuInterop.js- Added validation and consistent error handlingsliderInterop.js- Enhanced error handling and documentationtabsInterop.js- Improved validation and error handlingtreeInterop.js- Added comprehensive error handling and validationindex.js- Enhanced AG Grid and ECharts integration with safety improvementsC# files:
FileUploadInterop.cs: Reduced from 184 to 72 lines (61% reduction)TabsInterop.cs: Reduced from 226 to 68 lines (70% reduction)BaseInterop.cs: Reduced from ~180 to ~80 lines (56% reduction)BaseJSInterop.cs- New shared base class (268 lines of reusable infrastructure)Key improvements:
Please don't merge this PR without proper testing!
🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
dotnet test)dotnet build, changes pushed)👨💻 Help & support