Implement basic support for broker version > 2.0.1 #116
+57
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we have a sso_url (which is only used for the PrtSsoCookie), we need to use type 8. Otherwise the type is 1 (as observed via DBus). This change is needed for brokers > 2.0.1. Xref: #108 Signed-off-by: Felix Moessbauer <[email protected]>
The account is only needed as part of the authorization params, hence we do not need to add it to the higher-level params. Xref: #108 Signed-off-by: Felix Moessbauer <[email protected]>
In case the broker is newer than v2.0.1, the cookie data is further down in the json response data. Account for that. Xref: #108 Signed-off-by: Felix Moessbauer <[email protected]>
Brokers > 2.0.1 do not implement the introspection interface. To mitigate this, we create the dbus proxy object directly from a local copy of the dbus broker interface spec. Xref: #108 Signed-off-by: Felix Moessbauer <[email protected]>
fmoessbauer
force-pushed
the
fm/broker-2.0.2-plus-support
branch
from
9f6a1e6 to
08a1711
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the acquisition of PRT SSO cookies compatible with broker versions > 2.0.1. If fetching the device state information and profile picture works depends on more factors, as discussed in #114 .
With the limited support for 2.0.2+, we still keep the banner in the readme regarding compatible broker versions. Once the remaining issues on the newer broker versions are sorted out, we can remove the note.
Note, that the dbus interface changes are based on our experiments in siemens/sso-mib#26.
The webextension part is still fully compatible with older native (python script) versions, however to get support for new brokers both components need to be updated.