cmake: respect explicit install prefix#68
Open
iillyyaa wants to merge 1 commit intosierrafoxtrot:masterfrom
Open
cmake: respect explicit install prefix#68iillyyaa wants to merge 1 commit intosierrafoxtrot:masterfrom
iillyyaa wants to merge 1 commit intosierrafoxtrot:masterfrom
Conversation
If CMAKE_INSTALL_PREFIX was supplied externally, use it. This follows the pattern suggested by cmake documentation in: https://cmake.org/cmake/help/latest/variable/CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If CMAKE_INSTALL_PREFIX was supplied externally, use it. This follows the pattern suggested by cmake documentation in:
https://cmake.org/cmake/help/latest/variable/CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT.html
I took the liberty of removing (rather than fixing) the commented out line of code, because that reduces the testing surface I needed to cover. I hope that is acceptable.
The original motivation for this fix is that srecord is packaged in yocto project's meta-openembedded layer, and its ignoring of the install prefix prevents it from staging correctly into the destination sysroot.
This addresses Issue #65