Open
Conversation
sieukrem
reviewed
Sep 6, 2020
| @@ -0,0 +1,29 @@ | |||
| /**! | |||
Contributor
Author
There was a problem hiding this comment.
The link is present in the beginning of each file. The problem is that
- When I added the file and the link, the primary purpose of adding the link of that was to give credit to the lib authors and to provide the link where I can get the lib upgrade.
- CommonJS wrapper was removed. The lib names were either externed or exported to prevent their renamings and being optimized out.
- The stuff was then processed with Google Closure Compiler (a JS optimizer, not just in the sense of minification) on ADVANCED level. Then the code was formated using JSFormat plugin, to make the editing easier.
- Then I have done some manual fixes, since Google Closure Compiler on advanced level may spoil the code.
Each step was checked using dynamic code execution in CurrentView.
All of these were done long long long ago (I don't remember how long exactly, the time in git commit is fake, I have splitted a large commit into multiple ones, and that large commit had time of its last modification), probably we may need to upgrade the lib.
So there is not really a "non-minified" exist, I have not kept it.
I have given you the general recepie what should be done in order to upgrade the lib. Or maybe we need some kind of script doing this automatically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.