Skip to content

Prevent needlessly escapeing player names #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
magneticflux- wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Prevent needlessly escapeing player names #58

magneticflux- wants to merge 1 commit into from

Conversation

@magneticflux-
Copy link

@magneticflux- magneticflux- commented Apr 26, 2021 •
edited
Loading

Handlebars already does this, so doing it twice causes issues: https://handlebarsjs.com/guide/expressions.html#html-escaping
Closes #57

@magneticflux-
Copy link
Author

magneticflux- commented Apr 26, 2021

typescript-eslint seems to have updated and broken CI. It wasn't pinned and the lockfile isn't committed so npm ci didn't run, which let it select the most recent version. Commit your package-lock.json! It's there for a reason!

a000fb1 😠

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Names on the game over screen are HTML escaped

1 participant

@magneticflux-