Respect "can rotate" property of Shapes and Negative Shapes individually#104
Open
NewSoupVi wants to merge 2 commits intosigma144:masterfrom
Open
Respect "can rotate" property of Shapes and Negative Shapes individually#104NewSoupVi wants to merge 2 commits intosigma144:masterfrom
NewSoupVi wants to merge 2 commits intosigma144:masterfrom
Conversation
Author
|
Testing whether this has adverse effects on any other puzzles. (Don't mind the weird coloring, it's an Archipelago feature)
|
Author
|
|
Author
|
It does actually affect Sigma Rando Desert Vault.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Variety generates a puzzle with 3 Rotated Shapes and 3 Non-Rotated Negative Shapes.
However, it gets a puzzle with 2 Rotated Shapes, 1 Non-Rotated Shape, 1 Rotated Negative Shape, and 2 Non-Rotated Negative Shapes.
This PR fixes that by tracking negative rotated shapes and regular rotated shapes separately.
Tested: Only on Variety Desert Vault. Idk how it affects things elsewhere.