fix: region calculation for puzzles with stones#109
Open
lkaesberg wants to merge 2 commits intosigma144:masterfrom
Open
fix: region calculation for puzzles with stones#109lkaesberg wants to merge 2 commits intosigma144:masterfrom
lkaesberg wants to merge 2 commits intosigma144:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation looks for how many stones are available in the puzzle, but if there is, for example, a puzzle with a 2x2 grid and 2 blue and 2 yellow stones, there should be only 2 regions and not 4 as the current version calculates. I created a new function that calculates the number of unique colors for a given shape. I think this should be more consistent with the expected behavior.
See also NewSoupVi#35