Conversation
|
Is there a description of what the larger changes were? Looks like there's a few big deletions (e: specifically of |
peternandersson
left a comment
There was a problem hiding this comment.
Why are we removing this packages/test/*?
| on: | ||
| push: | ||
| branches: | ||
| - canary |
There was a problem hiding this comment.
Are we still using this branch?
There was a problem hiding this comment.
we will not be using it actively, but since this is the branch our fork is based off of, we should keep it just in case we need to pull in changes from upstream
.codesandbox/ci.json
Outdated
| @@ -1,5 +1,5 @@ | |||
| { | |||
There was a problem hiding this comment.
Do we need to change this? I figure we're not actually using this for CI?
There was a problem hiding this comment.
yeah we can delete this since we aren't using codesandbox
| @@ -0,0 +1 @@ | |||
| v20.17.0 | |||
There was a problem hiding this comment.
Also just curious, why do we need a node version for this package?
There was a problem hiding this comment.
this just ensures consistency across builds by ensuring all builds were generated using the same tooling
I removed |
rilescode
left a comment
There was a problem hiding this comment.
Nice. Would it make sense to update the READMEs as well?
ie npm install @stitches/core -> npm install @sigmacomputing/stitches-core etc
let's do this when we start publishing the packages publicly |
979e79d to
30c8f7e
Compare
renames packages from
@stitches/*to@sigmacomputing/stitches-*for publishing, and updates supporting files to work with yarn v4 and node 20