Skip to content

Experimental icl#1

Open
Jbruner23 wants to merge 8 commits intomainfrom
experimental_ICL
Open

Experimental icl#1
Jbruner23 wants to merge 8 commits intomainfrom
experimental_ICL

Conversation

@Jbruner23
Copy link
Collaborator

add files and code for experimenting ICL for illustrations
codebase taken from https://github.com/garibida/cross-image-attention

experimental In Context Learning for illustrations 
codebase taken from https://github.com/garibida/cross-image-attention
images for experiments
Colab notebooks
Copy link
Contributor

@AmitMY AmitMY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start! left a few general comments, mostly to organize the files better.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add **/__pycache__ to .gitignore file
then, use git to rm all pycache files from the branch

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all the code for this implementation should be under video_illustration (the main codebase) then cross_img_icl -> video_illustration/cross_img_icl

That way, each "solution" can be separate, but they can import from eachother

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all images should be appropriately named (e.g. "two_airplanes_512.jpg")

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i need the stem reference

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if multiple images belong to a "cluster", please create a directory, (for example "airplane") under which you have a "original.jpg", "original_512.png", "mask.png", "mask_512.png"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make this comment here for lack of a better place -
under cross_img_icl there should be a README.md file.
It can be as simple as:

# Cross Image ICL (btw i'm not sure what ICL mean, why not Cross Image Attention?)

Implementation copied from https://github.com/garibida/cross-image-attention

Setup and usage are the same as the above repository.

## Example
After setup etc, you can run
....

This is to help reproducibility, and so we can run this on the same files and expect the same result~

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the codebase from Cross-Image-Attention paper with small changes. ICL means In Context Learning (which might be the suitable task in computer vision)

Janna added 5 commits December 9, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants